Repository navigation
Exclude cancellation from failure types and simplify failure helpers - #60
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancellation no longer appears in declared failure types. A promise typed
CancelablePromise<T, E>now reports onlyE, and the cancel reason stays a runtime concern, so acatchhandler sees the declared failures and nothing else.The failure helpers are simpler to call.
withFailuretakes several failure types and error matchers, andfaildeclares the failure it rejects with, soCancelablePromise.fail(error)andLazyPromise.fail(error)need no options argument. A rethrowing or translatingcatchkeeps the failures it declared.The open set of failures is explicit.
Unlistedmarks a failure set as open, and an already open set keeps one marker instead of listing it twice. Native promises read asUnlisted, andTOrUnlistedleaves a closed set closed.Lazy promises strip cancellation from their failure carrier, so
LazyPromisefailures matchCancelablePromisefailures.Breaking changes are listed in the changelog with migration notes for each affected package.