Skip to content

fix: validation miss for mutable: true, until: mutate #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lczyk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: validation miss for mutable: true, until: mutate #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2584bc8
fix: script writes to mutable paths with until set to mutate
lczyk Oct 10, 2026
d8b1f63
fix: reject mutable paths with until set to mutate
lczyk Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions internal/setup/setup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,18 @@ var setupTests = []setupTest{{
`,
},
relerror: `slice mypkg_myslice mutable is not a regular file: /path`,
}, {
summary: "Mutable path cannot have 'until' set to mutate",
input: map[string]string{
"slices/mydir/mypkg.yaml": `
package: mypkg
slices:
myslice:
contents:
/path: {text: data, mutable: true, until: mutate}
`,
},
relerror: `slice mypkg_myslice cannot have both 'mutable' and 'until: mutate' for path /path`,
}, {
summary: "Until checks its value for validity",
input: map[string]string{
Expand Down
3 changes: 3 additions & 0 deletions internal/setup/yaml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,9 @@ func parsePackage(release *Release, pkgName, pkgPath string, data []byte) (*Pack
if mutable && kinds[0] != TextPath && (kinds[0] != CopyPath || isDir) {
return nil, fmt.Errorf("slice %s_%s mutable is not a regular file: %s", pkg.Name, sliceName, contPath)
}
if mutable && until == UntilMutate {
return nil, fmt.Errorf("slice %s_%s cannot have both 'mutable' and 'until: mutate' for path %s", pkg.Name, sliceName, contPath)
}
slice.Contents[contPath] = PathInfo{
Kind: kinds[0],
Info: info,
Expand Down
Loading