Skip to content

Adding LRM definition#75

Open
stiandel wants to merge 1 commit into
canonical:mainfrom
stiandel:9_Adding_LRM
Open

Adding LRM definition#75
stiandel wants to merge 1 commit into
canonical:mainfrom
stiandel:9_Adding_LRM

Conversation

@stiandel

Copy link
Copy Markdown

Fixes #9 (comment)

The definition of LRM has been added to the glossary.

@stiandel
stiandel requested a review from AnneCYH as a code owner July 16, 2025 04:05

@anthonywong anthonywong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnneCYH AnneCYH left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @stiandel !

I apologize for missing the PR.

@AnneCYH
AnneCYH self-requested a review July 16, 2026 08:03

@AnneCYH AnneCYH left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stiandel , thanks very much for your contribution!

I marked it as "Request changes" not because of the content per se but some other aspects that need to be fixed first.

  1. Could you please rebase your fork with upstream/main first?
  2. Your commit should adhere to the conventional commit style.
  3. You'd also need to sign off on your commits.
docs(ref/glossary): add LRM definition

Signed-off-by: Your Name <your@email.com>

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glossary - LRM

3 participants