Repository navigation
GitHub: Run weekly tests with MicroCloud 2 and 3 - #1639
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The change still has an active moderate issue because debug binaries remain enabled by default for the upgrade test, and coverage uploads are not fully gated for the MicroCloud 2/3 jobs.
2 open issues
What changed in this PR
Updates GitHub Actions system tests to cover MicroCloud 2, 3, and latest/edge, while limiting debug-binary sideloading and coverage collection to latest/edge tests.
Changes:
- Expands the system-test matrix with MicroCloud 2/edge and 3/edge combinations.
- Adds channel-specific controls for debug-binary sideloading and coverage collection.
- Makes debug-binary downloads, sideloading, and stripping conditional.
| File | Summary | Review findings |
|---|---|---|
.github/workflows/tests.yml |
Expands the MicroCloud test matrix and configures version-specific coverage and binary sideloading. | Nit: MicroCloud 2/3 jobs may still attempt coverage uploads when GOCOVERDIR is set; gate the upload on collect_coverage == 'true'. |
.github/actions/system-test/action.yml |
Adds conditional handling for downloading, sideloading, and stripping debug binaries. | Moderate: sideload_debug_binaries remains enabled by default, causing the upgrade job to sideload checkout-built debug binaries. Default it to false. |
Review effort: Lite
roosterfish
marked this pull request as draft
October 27, 2026 21:26
roosterfish
force-pushed
the
fix_weekly_tests
branch
from
October 27, 2026 21:44
735543a to
0d7c072
Compare
This helps testing MicroCloud versions which don't match to the branch the test is running on. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
Also test the latest/edge snap and use it as the base when injecting the binaries built from (main). For all other versions don't inject binaries. Also only collect coverage for latest/edge. Signed-off-by: Julian Pelizäus <julian.pelizaeus@canonical.com>
roosterfish
force-pushed
the
fix_weekly_tests
branch
from
October 28, 2026 17:03
0d7c072 to
8fda659
Compare
roosterfish
marked this pull request as ready for review
October 28, 2026 17:20
simondeziel
approved these changes
Oct 28, 2026
MusicDin
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the current situation which always tries injecting the MicroCloud debug binaries built from
mainbranch.Instead run the weekly tests with MicroCloud 2, 3 and latest/edge.
Only in the latest/edge case inject debug binaries and collect coverage.