Skip to content

verify is_notable_action? is working #53

Description

@outofambit

i think i keep seeing my pr status get reevaluated when i make non-code changes to the pr

if there's a bug, its likely in https://github.com/carbonfive/funnel/blob/f0ab433e3d424955754e3eaed470ff4a567c616a/lib/funnel/investigator/helpers.ex#L55-57

we need to make sure that this function only returns true for "opened", "reopened", and "synchronize". and that Investigator is using that value to skip investigation when is_notable_action? returns false.

more context from the GitHub API docs: https://developer.github.com/v3/activity/events/types/#pullrequestevent

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions