Repository navigation
fix(syntax): let injected markdown inherit doc comment color - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injected markdown overrode doc comment color
Languages that inject
markdowninto documentation strings/comments (e.g. Elixir@doc/@moduledoc) rendered their prose in the bright foreground color instead ofthe muted comment color. Zed's markdown grammar captures every
(paragraph)as@text, and the theme mappedtext→c.text, which sat on top of the parentcomment.dochighlight.Fix: remove the
textsyntax rule. Zed only pushes a highlight when the captureresolves to a theme key, so with no
textrule the paragraph inherits theenclosing style. Plain
.mdfiles are unaffected: unhighlighted paragraphs fallback to the editor's default
colors.text, which is the same value.Zed's bundled themes already follow this convention:
assets/themes/one/one.json),assets/themes/ayu/ayu.json), andassets/themes/gruvbox/gruvbox.json)each define
text.literalbut no baretextrule, so injected markdown proseinherits the enclosing style (e.g.
comment.doc) in those themes.Screenshots
Before
Unusable. Doc comments inject markdown, so everything is just normal bright text. Comments don't look like comments.
After
Comments look like comments, and sanity is restored.