Repository navigation
Handle repeated Boolean options consistently - #620
Open
JimmyLiuJia wants to merge 1 commit into
Open
JimmyLiuJia wants to merge 1 commit into
JimmyLiuJia wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #530.
Boolean options previously flipped their current value on every occurrence. Repeating a flag could therefore restore its initial value, including
-y -yturningdryRunback tofalse.Use the parameter's existing assigned state to handle repeated Boolean options consistently with scalar parameters: reject a repeat by default, and leave the first value in place when
allowParameterOverwriting(true)is set. This applies to both implicit Boolean arity and explicitarity = 0.Both new regressions failed against the unchanged implementation and pass with the fix. Validation: Gradle
checkpassed on Java 21 with 340 tests, 0 failures, 0 errors, and 0 skipped. Local validation used installed Gradle 9.8.0 because the wrapper's 9.7.1 download timed out.AI assistance was used to investigate, implement, test, and draft this PR.