[cherry-pick][6.10]CDAP-21261 : Add retry logging for GCP Secret Manager SDK calls - #16234
Merged
sahusanket merged 2 commits intoSep 25, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request configures a custom tracer factory (BaseApiTracerFactory) on the GCP Secret Manager client stub settings. This tracer logs warnings when quota limits are hit (RESOURCE_EXHAUSTED), debug messages for other transient failures during retries, and errors when retries are exhausted. There are no review comments, so we have no additional feedback to provide.
sahusanket
force-pushed
the
cherry_CDAP-21261_secretmanager_retry_logging_and_backoff
branch
from
September 25, 2026 03:54
4769986 to
78c53c5
Compare
sahusanket
deleted the
cherry_CDAP-21261_secretmanager_retry_logging_and_backoff
branch
September 25, 2026 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original pr : #16233
Note on
cdap-securityTest Keystore Changes (server-key.jks,client-key.jks,server-trust.jks)CDAP-21261: These test resource updates incdap-securityare unrelated to the Secret Manager retry logging changes.cdap-security/src/test/resources/onrelease/6.10(originally generated on Sep 23, 2016) expired on Sep 23, 2026, causingExternalMTLSAuthenticationServerTestto fail in CI withjava.security.cert.CertificateExpiredException. Replacing them with the renewed test keystores fromdevelop(valid until June 2034) unblocks CI onrelease/6.10.