Repository navigation
fix: GitHub IP ranges grow too large for Security Groups - #1955
Merged
Merged
Conversation
We are restricting outbound network access for the Transliterator to known NPM and GitHub IP addresses, using Security Group rules. Problem is that security groups can have at most 60 rules, and these IP ranges are ever-growing as GitHub is expanding its infrastructure, and are currently up to 80+ rules. I *think* we have no need to contact GitHub at all, but I also don't want to mess with existing infra too much. So I've done the next cheapest thing: merge IP ranges with the smallest distance until we are under the limit of 60 again, so we can deploy.
cdklabs-automation
enabled auto-merge
November 12, 2026 11:01
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
mrgrain
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are restricting outbound network access for the Transliterator to known NPM and GitHub IP addresses, using Security Group rules.
Problem is that security groups can have at most 60 rules, and these IP ranges are ever-growing as GitHub is expanding its infrastructure, and are currently up to 80+ rules.
I think we have no need to contact GitHub at all, but I also don't want to mess with existing infra too much. So I've done the next cheapest thing: merge IP ranges with the smallest distance until we are under the limit of 60 again, so we can deploy.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license