[AMGXWrapper][CUDA] Enable position independent code globally#19
Open
fmgjcoppens wants to merge 1 commit into
Open
[AMGXWrapper][CUDA] Enable position independent code globally#19fmgjcoppens wants to merge 1 commit into
fmgjcoppens wants to merge 1 commit into
Conversation
By enabling position indendend code at CMake level -fPIC is automatically passed to all compilers that support it. `-DCMAKE_CXX_FLAGS=-fPIC` is not propagated correctly to the host compiler when compiling .cu-files. This causes the ICoCo build later to fail in the linking stage.
fmgjcoppens
force-pushed
the
coppens/fix_build_amgxwrapper
branch
from
July 17, 2026 20:27
488429c to
fc2451b
Compare
fmgjcoppens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the ICoCo build when CUDA is enabled. By activating position independent code at CMake level,
-fPICis automatically passed to all compilers that support it.-DCMAKE_CXX_FLAGS=-fPICis not propagated correctly to the hostcompiler when compiling .cu-files. This causes the ICoCo build later to
fail in the linking stage.