fix(cli): quote Windows shell args for background processes - #2333
Closed
simoncrypta wants to merge 1 commit into
Closed
fix(cli): quote Windows shell args for background processes#2333simoncrypta wants to merge 1 commit into
simoncrypta wants to merge 1 commit into
Conversation
👷 Deploy request for cedarjs pending review.Visit the deploys page to approve it
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 1s | View ↗ |
nx run-many -t build --output-style=stream |
✅ Succeeded | 2s | View ↗ |
nx run-many -t test --maxWorkers=4 |
✅ Succeeded | 1m 24s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 10s | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-08-05 15:54:52 UTC
Tobbe
reviewed
Aug 6, 2026
Telemetry and update-check spawn with shell: true on Windows. Paths with spaces were split into extra argv tokens, so Node loaded a truncated module and threw MODULE_NOT_FOUND.
simoncrypta
force-pushed
the
fix/windows-shell-quote-background
branch
from
August 31, 2026 02:33
e2d1b4c to
7de8222
Compare
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
cmd.exe/shell: truearguments inspawnBackgroundProcessso paths with spaces (e.g. CItest project) do not split into truncated MODULE_NOT_FOUND failuresstderrin smoke configs for clearer failure outputSplit out of #2283 so that PR stays focused on
@cedarjs/pglocal Postgres integration.Test plan
quoteWindowsShellArg