fix(nav): remove duplicate odis-use-case-phone-number-privacy entry from the Legacy ODIS group - #2272
Open
GigaHierz wants to merge 1 commit into
Open
fix(nav): remove duplicate odis-use-case-phone-number-privacy entry from the Legacy ODIS group#2272GigaHierz wants to merge 1 commit into
GigaHierz wants to merge 1 commit into
Conversation
…rom the Legacy ODIS group Closes #2240 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hole, and the fix
legacy/protocol/identity/odis-use-case-phone-number-privacywas listed twice indocs.jsonnavigation: once directly under the ODIS group (line 581) and again inside its nested Use Cases sub-group (line 585), next to its siblingodis-use-case-key-hardening. The sidebar showed the page twice. This deletes the group-level copy; the nested one is the right home because its sibling lives there.What this does NOT do / residual risk
One-line deletion in the Legacy nav block; no content, redirects or other nav touched. The whole Legacy block is removed later by #2254 — this just stops the double entry until then.
Judgement calls
Kept the nested entry, dropped the group-level one (the page is a "use case", same as its sibling). Reversible by swapping which line is deleted.
Issues
Closes #2240 — the single acceptance condition (no duplicate nav entries) is met and checked below.
Stacking / conflicts
Branched off
main, independent. #2254 will delete this block wholesale; if it lands first this PR becomes a no-op and can be closed.Verification evidence
Before this change on
main(bdf40b37): 265 raw, 264 unique.Remaining ops steps
Checklist
mainmint broken-linkspasses; nav has no duplicates