espresso: delete dead supporting code - #512
Merged
Merged
Conversation
Remove code with no callers: espresso/ethclient.go (duplicates batcherL1Adapter; FetchEspressoBatcherAddress belongs to the caff node in another repo), opcrypto.Verify and its test, and the AllowEmptyAttestationService escape hatch, which nothing sets, so Check() now requires the attestation service URL unconditionally. Also drop a doc reference to DebouncingHandler, which does not exist.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #459. Removes supporting code added there that has no callers.
espresso/ethclient.go:AdaptL1BlockRefClientduplicatesbatcherL1Adapterinop-batcher/batcher/espresso_driver.go, andFetchEspressoBatcherAddressis for the caff node, which lives in another repo.opcrypto.Verifyand its test: called only by the test. Its doc comment also described message-based verification while the implementation requires a 32-byte digest, so leaving it invites misuse.AllowEmptyAttestationService: nothing calls the setter, so the private field was always false.Check()now requires the attestation service URL unconditionally, which is what already happened in practice.op-service/log/repeat_state.gocontrastedRepeatStateLoggerwith aDebouncingHandlerthat does not exist in this repo. Reworded to state the actual distinction.Verified with
go buildandgo veton the touched packages, plusgo testonop-service/crypto,op-service/logandop-batcher/batcher.