Add boilerplate module to project#656
Merged
cert-manager-prow[bot] merged 1 commit intoJun 22, 2026
Merged
Conversation
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
Member
Author
|
/cc @inteon |
There was a problem hiding this comment.
Pull request overview
This PR integrates the existing boilerplate makefile-module into this repository’s top-level Makefile, so that boilerplate/license header verification is included in the standard make verify flow and the repo no longer duplicates the target definition locally.
Changes:
- Include
modules/boilerplate/00_mod.mkandmodules/boilerplate/01_mod.mkin the rootMakefile. - Remove the locally defined
verify-boilerplatetarget from the rootMakefile(now provided by the module). - Document the
boilerplatemodule in the list of modules used by this repo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the boilerplate module to the makefile-modules own make setup. This will ensure the boilerplate check is included in
make verify, and also reduce duplication.