Repository navigation
ci: Add the /signoff PR command - #16
Draft
cgwalters-bot wants to merge 1 commit into
Draft
cgwalters-bot wants to merge 1 commit into
cgwalters-bot wants to merge 1 commit into
Conversation
DCO is a required check here, and PRs from contributors who forgot to sign off (or from the bot, which never does) sit blocked until someone rewrites them by hand. This lets a maintainer comment `/signoff` to add their own Signed-off-by to all of a PR's commits, leaving them otherwise unchanged, or `/rebase-signoff` to also rebase onto main. The file is the org-wide stub from bootc-dev/infra's common/ directory, which sync-common will install everywhere; adding it here first just gets it to bootc sooner, and the sync then finds it already identical. The logic is the pr-signoff reusable workflow in bootc-dev/actions. Other comments only produce a skipped run, without a runner. Generated-by: AI
cgwalters-bot
force-pushed
the
bot/signoff-command
branch
from
September 24, 2026 23:50
7e606cd to
c11a46c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
/signoffPR command. A maintainer comments/signoff, and theirSigned-off-byis added to all of the PR's commits, which otherwise stay byte for byte the same./rebase-signoffalso moves the commits onto main. DCO is a required check here, so PRs from contributors who forgot to sign off, and all of cgwalters-bot's PRs, stay blocked until someone rewrites them by hand.The file is the org-wide stub from bootc-dev/infra's
common/(cgwalters-forge/infra#8). Adding it here first just gets it to bootc sooner; the sync then finds an identical file. The logic is thepr-signoffreusable workflow in bootc-dev/actions (cgwalters-forge/actions#2), which has the design, the security notes and the test runs.It uses the bootc-bot App, whose credentials (
GH_AW_APP_CLIENT_ID/GH_AW_APP_PRIVATE_KEY) are installed org-wide on bootc-dev, so nothing needs setting up here. The stub pins that workflow by commit, since it hands over the bootc-bot App key. The pin is currently the actions PR's head, and must be bumped to the commit that lands in bootc-dev/actions before merging.It doesn't touch the merge queue: it runs only for
issue_comment, and dco-2 already passesmerge_groupchecks by itself. Like any push, the signoff push removes a queued PR from the queue, so sign off before queueing.actionlint is clean. The same stub was tested on cgwalters-forge/infra (see the actions PR). The App-token path is untested and needs one real run before anyone relies on it.
Related: bootc-dev/infra#260
Generated-by: https://github.com/cgwalters/#llms
Review draft in cgwalters-forge, not upstream yet. This section is removed when the PR is opened upstream.
bootc-dev/bootc, basemainPVTI_lADOE9oHIs4BlJLczg9kERgTo review:
/promoteon a line of its own, to open it upstream, ready for review. Either covers only the commits pushed so far.Signed-off-by: Colin Walters <walters@verbum.org>to the commits lacking it (the bot's and yours; anyone else's only if you ask), with you as committer./draftline (in the same comment or before) to open it upstream as a draft (/readyundoes that).