Repository navigation
docs(ranui): clarify layout alignment and boundary hierarchy - #434
Merged
Merged
Conversation
Deploying ran with
|
| Latest commit: |
5ee4efa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9fbaa387.ran-4ty.pages.dev |
| Branch Preview URL: | https://codex-layout-contract.ran-4ty.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Verdict
[APPROVE] — The change defines and exercises composition acceptance without changing component behavior or foundation values.
Summary
An aligned button rectangle can hide an inset label, while a flexible title trigger can make unused toolbar space clickable. Extend the layout standard to distinguish frame, content, text, icon viewport and hit-area geometry, declare alignment spines and navigation columns, and require browser evidence for the layer that actually drifts.
Update the canonical guidance, interface/workflow entry points and English/Chinese consumer guides. Add a runnable browser example that rejects text-only drift, expanded title targets and sibling drift, then verifies restoration. The companion document-editor PR #289 applies this contract across its assistant workspace.
Clarify constrained-pane command hierarchy: remove redundant group enclosures while retaining recognizable resting affordance for standalone native buttons. Flat rows suit established menu/list contexts; they are not mandatory for all settings commands. Every persistent outline, surface fill or separator needs a distinct job; a nested card and row rules must not repeat grouping already expressed by type, alignment and proximity. Preserve functional field frames and focus/selection cues, separate destructive commands from explicit confirmation, and inspect the complete pane when accepting a composition. Require shared icon/checkbox and text columns across adjacent controls, distinguish hit-target gutter extensions, and inspect the resting full pane without relying on hover or cursor changes. Carry the rule into the verification brief and English/Chinese guides.
Risk Analysis
Design Decisions
Code Concerns
No outstanding actionable findings after review.
Verification
pnpm verify:links,pnpm verify:docs, eight-locale checks, changed-file Prettier andgit diff --checkpassed.pnpm -F ranui test: 1,577 unit/integration tests and 76 SSR tests passed; typecheck passed.pnpm -F ranui buildandpnpm -F docs testpassed (145 docs tests).Conclusion basis: real-browser geometry, pointer/keyboard paths, mutation/restoration checks and local package gates. CSS zoom is reflow stress coverage; native browser zoom remains a consumer acceptance responsibility.