ci: Fix build of ubi8-based assembly - #776
Conversation
…nstall Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Assisted-by: Cursor AI
Both base images already ship a compatible Python: - ubi8/nodejs-22 has Python 3.12 (via Node.js RPM dependency) - ubi9/nodejs-22 has Python 3.9 (RHEL 9 platform python) node-gyp 11.5.0 supports both versions, so the explicit python3.9 install is unnecessary. Signed-off-by: Roman Nikitenko <rnikiten@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-776-amd64 |
1 similar comment
|
Pull Request images published ✨ Editor amd64: quay.io/che-incubator-pull-requests/che-code:pr-776-amd64 |
📝 WalkthroughWalkthroughThe UBI8 builder no longer installs Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
npm installfails during Docker build onlinux-libc-ubi8.Dockerfilewith:Root cause: Red Hat's
ubi8/nodejs-24(andnodejs-22) images ship node-gyp's gyp_main.py with shebang#!/usr/bin/python3.8(baked in by brp-mangle-shebangs during RPM build), but the actual Python in the image is3.12at/usr/bin/python3.Fix: Add
sedto rewrite the shebang to#!/usr/bin/python3alongside the existingchmod +xinlinux-libc-ubi8.DockerfileWhat issues does this PR fix?
https://redhat.atlassian.net/browse/CRW-12125
How to test this PR?
ubi8-based assembly should be built without errors
Does this PR contain changes that override default upstream Code-OSS behavior?
git rebasewere added to the .rebase folderSummary by CodeRabbit