Repository navigation
fix(http): send every HTTP verb in uppercase - #474
Merged
armando-rodriguez-cko merged 1 commit intoOct 23, 2026
Merged
Conversation
The default fetch client passed the method in lowercase. fetch only normalises DELETE, GET, HEAD, OPTIONS, POST and PUT, so PATCH went out as "patch" and the API answered 400. Every PATCH operation failed with the default client; axios was not affected. The method is now uppercased once in httpRequest for both clients. New tests read the method on a local server for GET, POST, PATCH, PUT and DELETE with fetch and axios, since nock matches the method case-insensitively and could not catch this.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 2 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The change is a pure bug fix that uppercases the HTTP method string in an existing code path, touching no auth logic, no data persistence, no new endpoints or integrations, and no external boundaries.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…
david-ruiz-cko
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
With the default fetch client every PATCH request failed with 400. The method was passed to fetch in lowercase, and fetch only normalises DELETE, GET, HEAD, OPTIONS, POST and PUT, so
patchreached the API as-is. The axios client was not affected. Every verb is now sent in uppercase on both clients.Changes
src/services/http.js:httpRequestuppercases the method once before choosing the client; the OAuth token request usesPOSTtest/http/httpMethod.js: new tests that read the method on a local HTTP server for GET, POST, PATCH, PUT and DELETE with both the fetch and axios clients (nock matches the method case-insensitively, so it could not catch this)Verified against the sandbox with the default client: updating a customer returned 400 before the change and succeeds after it.
API Reference
Every PATCH operation the SDK exposes, for example:
PATCH /customers/{identifier}: https://api-reference.checkout.com/tag/customers/PATCH/customers/%7Bidentifier%7DBreaking changes
None.
README
No change needed.