Skip to content

fix(deps): update axios and follow-redirects to patched versions - #475

Merged
armando-rodriguez-cko merged 1 commit into
masterfrom
fix/INT-1751-security-alerts-node
Oct 23, 2026
Merged

armando-rodriguez-cko merged 1 commit into
masterfrom
fix/INT-1751-security-alerts-node

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary
Updates the runtime dependencies to versions that fix the open security advisories: axios 1.20.0 and follow-redirects 1.16.1. The lockfile refresh also moves the development tooling to patched versions, and the build workflows are hardened.

Changes

  • package.json: axios ^1.20.0; overrides follow-redirects ^1.16.1 and js-yaml ^4.3.2
  • package-lock.json: refreshed; development tooling on patched versions (js-yaml, browserslist, brace-expansion, @humanfs/node, baseline-browser-mapping)
  • .github/workflows/build-pull-request.yml, .github/workflows/build-master.yml: read-only contents permission and npm ci --ignore-scripts

npm audit --omit=dev reports no vulnerabilities. Unit tests and the build smoke test pass.

API Reference
None, no API surface change.

Breaking changes
None.

README
No change needed.

axios 1.20.0 and follow-redirects 1.16.1 fix the open advisories on the runtime dependencies the SDK ships. The lockfile refresh also moves the development tooling to patched versions (js-yaml, browserslist, brace-expansion, @humanfs/node, baseline-browser-mapping). npm audit --omit=dev reports no vulnerabilities.

The build workflows now declare read-only contents permissions and install with --ignore-scripts.
@armando-rodriguez-cko
armando-rodriguez-cko requested a review from a team October 23, 2026 12:59
@agent-wall-e

agent-wall-e Bot commented Oct 23, 2026

Copy link
Copy Markdown

🔴 Risk Classification: MAJOR

Approval route: AI Review + Human Approval Required
Rollback controls: Change-freeze window + documented rollback plan

Classification reasons

  • security_sensitive_path:.github/workflows/build-master.yml
  • security_sensitive_path:.github/workflows/build-pull-request.yml

Operational gates

  • ✅ jira_ticket (INT-1751)
  • ✅ independent_review

Files analysed: 4


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 23, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
security_sensitive_path — .github/workflows/build-master.yml classifying §2.1 M4/M5 Path matched a sensitive pattern (auth, secrets, crypto, PCI, migrations, network IaC).
security_sensitive_path — .github/workflows/build-pull-request.yml classifying §2.1 M4/M5 Path matched a sensitive pattern (auth, secrets, crypto, PCI, migrations, network IaC).

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 23, 2026

Copy link
Copy Markdown

🟢 Advisory review: Looks good to me

This PR still needs a human approval — wall-e cannot auto-approve it. For what it's worth, I read the diff and found nothing I'd block on.

Bumps axios to ^1.20.0, tightens follow-redirects and js-yaml overrides to patched versions, refreshes the lockfile, and hardens CI workflows with read-only permissions and --ignore-scripts. All changes match the stated intent and appear correct.

What I checked

  • axios dependency correctly updated from ^1.18.0 to ^1.20.0 in package.json
  • follow-redirects override tightened from ^1.16.0 to ^1.16.1 as claimed
  • js-yaml override tightened from ^4.2.0 to ^4.3.2 as claimed
  • contents: read permission added to both workflow files, limiting the GITHUB_TOKEN blast radius appropriately
  • npm ci --ignore-scripts prevents postinstall script execution during CI, which is a sound hardening measure; worth confirming no required build-time scripts are skipped, but standard for a library like this
  • Missing newline at end of build-master.yml is a minor pre-existing issue carried over in this diff, not introduced by this PR

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@armando-rodriguez-cko
armando-rodriguez-cko merged commit 5f5ec1b into master Oct 23, 2026
6 checks passed
@armando-rodriguez-cko
armando-rodriguez-cko deleted the fix/INT-1751-security-alerts-node branch October 23, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants