Skip to content

Release 4.8.0 - #255

Merged
rodrigojara-cko merged 1 commit into
mainfrom
release/4.8.0
Oct 22, 2026
Merged

rodrigojara-cko merged 1 commit into
mainfrom
release/4.8.0

Conversation

@rodrigojara-cko

Copy link
Copy Markdown
Contributor
  • Payment setups: Pay by Bank is sent under the paybybank key; the previous key was ignored by the API. Adds the Pay by Bank risk object.
  • Payment setups: card gains details (CardDetails), token (CardToken), schemes and preferred_scheme. Apple Pay and Google Pay gain schemes and preferred_scheme (Google Pay accepts visa and mastercard). Add payment_methods auto_confirm, metadata on the request and the read-only instrument type.

Breaking changes required by the API:

  • Payment setups: the Apple Pay and Google Pay token is now a WalletToken object (id, expires_on) instead of a str. The API never accepted a string token.

Deprecated:

  • The flat Card attributes (number, last4, bin, scheme, expiry_month, expiry_year, name, cvv, stored, expires_on, allow_update), which the API does not read. Use card.details.
  • ApplePay and GooglePay expires_on. Use token.expires_on.
  • PaymentMethods pay_by_bank, which the API ignores. Use paybybank.

- Payment setups: Pay by Bank is sent under the paybybank key; the previous key was ignored by the API. Adds the Pay by Bank risk object.
- Payment setups: card gains details (CardDetails), token (CardToken), schemes and preferred_scheme. Apple Pay and Google Pay gain schemes and preferred_scheme (Google Pay accepts visa and mastercard). Add payment_methods auto_confirm, metadata on the request and the read-only instrument type.

Breaking changes required by the API:
- Payment setups: the Apple Pay and Google Pay token is now a WalletToken object (id, expires_on) instead of a str. The API never accepted a string token.

Deprecated:
- The flat Card attributes (number, last4, bin, scheme, expiry_month, expiry_year, name, cvv, stored, expires_on, allow_update), which the API does not read. Use card.details.
- ApplePay and GooglePay expires_on. Use token.expires_on.
- PaymentMethods pay_by_bank, which the API ignores. Use paybybank.
@agent-wall-e

agent-wall-e Bot commented Oct 22, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 22, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 22, 2026

Copy link
Copy Markdown

🟠 Advisory review: Concerns worth a look

This PR needs a human approval. Before you give it, these are the things I'd want resolved.

The diff only bumps the version string, but the PR description claims significant API changes including new types, deprecated fields, and breaking changes — none of which appear in this diff.

Concerns

  • The entire described implementation (WalletToken, CardDetails, CardToken, Pay by Bank key rename, schemes/preferred_scheme fields, auto_confirm/metadata on payment_methods, etc.) is absent from the diff — either the diff is incomplete/partial, or the version is being bumped without the corresponding code changes.
  • If this is a partial diff, the reviewer cannot assess correctness of the described breaking changes (WalletToken replacing str) or verify that deprecated attributes are properly marked.
  • A version bump to 4.8.0 paired with a PR describing breaking API changes should only be approved once all described code changes are visible and verified.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@rodrigojara-cko rodrigojara-cko changed the title Release 4.8.0 - Payment setup alignment Release 4.8.0 Oct 22, 2026
@rodrigojara-cko
rodrigojara-cko requested a review from a team October 22, 2026 11:27
@rodrigojara-cko
rodrigojara-cko merged commit 3cf497c into main Oct 22, 2026
4 checks passed
@rodrigojara-cko
rodrigojara-cko deleted the release/4.8.0 branch October 22, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants