Repository navigation
docs(setups): use payment method status values from the spec - #222
Conversation
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 2 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
The Blik status doc and the payment-method serialization specs used "available", which is not a PaymentMethodStatus value. Use "ready" and point the doc at PaymentSetupPaymentMethodStatus.
2a9a361 to
59e0aa9
Compare
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 2 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The diff is purely a documentation string update and test fixture string replacement ('available' → 'ready') with no behavioral, structural, or data changes.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…
Document the status values on Bacs, CardPresent and Stablecoin as on Blik, map Blik to its swagger schema, add a Blik serialization spec, and use a valid initialization value (enabled) in the Bacs spec.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 5 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:All changes are doc comment updates and test fixture value corrections (string literals in specs), with no behavioral, logic, auth, persistence, or integration changes.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…
…t keys The Payment Setup client takes a Hash and documented only some of its keys. Document payment_methods card (token and details), applepay and googlepay (token_data and the token object), instrument and auto_confirm, settings capture and excluded_payment_methods, order sub_merchants number_of_sales and metadata, plus the read-only fields returned.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 6 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:All changes are purely documentation comments and test value corrections (replacing 'available' with 'ready') with no behavioral, logic, auth, data persistence, or integration changes.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…
… request keys Mark the wallet token id as required, add the phone length limits, the uri format of the redirect URLs, the type of every key, the write-only card and wallet fields, and the read-only response values (Google Pay schemes, set_instrument).
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 6 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The PR is purely documentation comments and test value corrections (replacing invalid 'available' with valid 'ready'), with no logic, behavior, auth, data persistence, new endpoints, or external integrations changed.
wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…



Summary
The Blik status doc and the payment method serialization specs used
"available", which is not aPaymentMethodStatusvalue in the Payment Setup spec (unavailable,action_required,ready,initialization_required,invalid). This switches them to"ready"and points the status doc of Blik, Bacs, CardPresent and Stablecoin atPaymentSetupPaymentMethodStatus. No behaviour change:statusis a String.The rest of the Payment Setup shape alignment done in the other SDKs (card details, wallet token object, sub-merchant
number_of_sales, settings,auto_confirm,metadata,instrument.type) needs no code change here:create_payment_setupandupdate_payment_setuptake a Hash and send it as is, and the SDK has no typed classes for those shapes. What was missing is the documentation of those keys on the client, added here.Changes
lib/checkout_sdk/payments/setups/blik_payment_method.rb,bacs_payment_method.rb,card_present_payment_method.rb,stablecoin_payment_method.rb: status doc uses a spec value and referencesPaymentSetupPaymentMethodStatus; Blik maps to its swagger schema.lib/checkout_sdk/payments/setups/payment_setups_client.rb: documentspayment_methods.card(token,details),applepayandgooglepay(token_data,tokenas an object),instrument,auto_confirm,settings.captureandexcluded_payment_methods,order.sub_merchants[].number_of_salesandmetadataon create and update, and the read-only fields returned.spec/checkout_sdk/payments/setups/setup_payment_methods_serialization_spec.rb:'available'replaced by'ready'for Bacs, CardPresent, PayByBank and Stablecoin, a validinitialization(enabled) in the Bacs spec, and a new Blik serialization spec.API Reference
POST /payments/setupsPUT /payments/setups/{id}GET /payments/setups/{id}POST /payments/setups/{id}/confirm/{payment_method_name}Breaking changes
None.
README
No change needed.