fix(gateway): cap Retry-After account cooldown at cooldownMax - #986
Open
lanting200 wants to merge 2 commits into
Open
fix(gateway): cap Retry-After account cooldown at cooldownMax#986lanting200 wants to merge 2 commits into
lanting200 wants to merge 2 commits into
Conversation
Upstream 504/429 Retry-After could freeze an account for hours because the selector applied it after the max-cooldown clamp. Honor cooldownMax for both exponential backoff and Retry-After. Co-authored-by: Cursor <cursoragent@cursor.com>
Official images apply upstream Retry-After after cooldownMax, and Python cannot parse Go's nanosecond timestamps, so the host clamp skipped the row. Truncate the fraction to microseconds and rewrite cooldown_until. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
routing.cooldownMaxeven when upstream sends a longRetry-After(for example a 504 with a 24h hint).Test plan
go test ./internal/application/gateway -run 'TestMarkFailureCapsRetryAfterAtCooldownMax|TestMarkFailureSoftNetworkCooldown'cooldownMaxelapses (not when Retry-After elapses)routing.cooldownBase/routing.cooldownMaxto1min admin settings and confirm the next failure cools for about one minuteMade with Cursor