forked from VladoPortos/folder.view2
-
Notifications
You must be signed in to change notification settings - Fork 2
fix: stuck folders can be deleted, and a failed delete no longer freezes the page #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chodeus
wants to merge
35
commits into
beta
Choose a base branch
from
fix/folder-id-validation
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+925
−633
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
5193227
fix: let any folder be deleted, and stop failed deletes freezing the …
b9e68d0
fix: re-key bad ids on full import, localise delete errors
a49b010
fix: tolerate hand-edited folder files and report failed requests
50ce621
fix: fail unreadable folder reads, translate new error text
961f7da
fix: 400 for non-string folder payloads, banner on Dashboard fallback
73a8c8c
fix: read every POST field through fv3_post_string()
67f84b9
fix: confine theme deletes to styles/, reject malformed theme requests
3e387b5
fix: reject malformed theme requests, delete dangling theme links
575efb5
fix: confine uploads to styles/, warn on a failed order sync
08ab5b0
fix: report theme files that could not be removed, show import and sy…
chodeus 5db750c
fix: show a failed theme delete as failed in the import dialog
chodeus f6dd19d
fix: re-sync the Docker start order after a single-folder import
chodeus 3ce96dd
fix: fail the folder read when the file is valid JSON but not a folde…
chodeus b9d1fdd
fix: stage theme imports and replace the installed theme only when ev…
chodeus 1ae0506
fix: accept an explicit empty folder id on delete, confine backup sty…
chodeus 74def57
refactor: share i18nOr and failReason, batch the settings-page reques…
chodeus c8c2a53
refactor: remove upload_theme.php, which nothing calls
chodeus ccca97f
refactor: move the theme functions from lib.php to themes.php
chodeus 8b0459c
fix: check theme renames and list reads, refuse clashing or oversized…
chodeus 007b919
fix: refuse a stored empty folder key, list disabled single-file them…
chodeus 47e57a7
fix: make the theme switch all or nothing, require fields whose absen…
chodeus 93d9a5c
fix: require an id on update.php
chodeus 0cb15fd
fix: treat an empty folder key as one folder on the settings page, fa…
chodeus 49fc562
fix: load an empty folder key in the editor, pass folder ids to inlin…
chodeus 51292fa
fix: escape folder ids in the Docker, VM and Dashboard folder templates
chodeus db2b4f4
fix: report failed file, style and generated-CSS writes during a back…
chodeus 33d56ef
fix: block save when editor setup fails, fail root imports with an un…
chodeus f9d9dcc
fix: fail a restore when a style folder can't be created, re-confine …
chodeus 9839d6f
fix: agree on one case-insensitive rule for a disabled theme, correct…
chodeus 0e6d139
fix: reject scalar JSON in the CSS config endpoint instead of a TypeE…
chodeus 8f433b8
fix: validate a restored css_config with the same rules an interactiv…
chodeus 958a403
fix: translate the settings page by waiting for the language pack and…
chodeus 0dd217a
fix: translate the theme labels the CSS tool injects, and use the sta…
chodeus 6939f3d
fix: name the preserved theme folder when a failed install cannot be …
chodeus 35ecac7
fix: return the installed theme entry so the import cleanup can delet…
chodeus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.