Repository navigation
fix(permissions): clear expired permission requests #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
83e8650
fix(permissions): clear expired permission requests
chriswritescode-dev 2b12fc3
style(worktree): drop the source badge corner radius
chriswritescode-dev 041ca20
fix(permissions): unify expired pending-action handling
chriswritescode-dev fa0cde5
test(permissions): lock the declared error tag as FetchError.code
chriswritescode-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: chriswritescode-dev/opencode-manager
Length of output: 41573
🏁 Script executed:
Repository: chriswritescode-dev/opencode-manager
Length of output: 8812
🌐 Web query:
@opencode/client version 2.0.15 generated client source declared error status response ClientError reason raw decoded body💡 Result:
🏁 Script executed:
Repository: chriswritescode-dev/opencode-manager
Length of output: 11527
🏁 Script executed:
Repository: chriswritescode-dev/opencode-manager
Length of output: 12803
🌐 Web query:
site:github.com/anomalyco/opencode/tree/v2.0.15/packages/httpapi-codegen OR site:github.com/anomalyco/opencode/blob/v2.0.15/packages/httpapi-codegen/src/index.ts "@opencode/client" 2.0.15 declared status error💡 Result:
🏁 Script executed:
Repository: chriswritescode-dev/opencode-manager
Length of output: 6538
🌐 Web query:
site:github.com/anomalyco/opencode/blob/v2.0.15 PermissionNotFoundError permission reply endpoint declaredStatuses generated OpenCode client npm @opencode/client💡 Result:
🏁 Script executed:
Repository: chriswritescode-dev/opencode-manager
Length of output: 41511
Preserve the declared error tag in
toFetchError.@opencode/client@2.0.15throws the decodedPermissionNotFoundErrorbody for the declared 404 response.toFetchErrorkeeps the status but drops_tag, sosettlePendingReplyrethrows the error and does not remove the expired request from the queue.Copy
_tagintoFetchError.codeand add a regression test throughreplyPermissionwith a decoded 404 response.🐛 Suggested fix
const status = openCodeErrorStatus(error) if (error instanceof Error) { return new FetchError(error.message, status ?? 0, error.name) } - return new FetchError('Request failed', status ?? 0) + const tag = error !== null && typeof error === 'object' + ? (error as { _tag?: unknown })._tag + : undefined + return new FetchError('Request failed', status ?? 0, typeof tag === 'string' ? tag : undefined) }🤖 Prompt for AI Agents