Repository navigation
Conversation
chzblych
force-pushed
the
codex/pr19783-container-deps
branch
3 times, most recently
from
November 1, 2026 15:40
d87501d to
171b3a5
Compare
chzblych
force-pushed
the
codex/pr19783-container-deps
branch
4 times, most recently
from
November 3, 2026 03:58
3b3cd5a to
0d7a4c9
Compare
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
chzblych
force-pushed
the
codex/pr19783-container-deps
branch
from
November 3, 2026 04:04
0d7a4c9 to
cd59d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued in NVIDIA/TensorRT-LLM#21516 using the same source branch and commit
cd59d75d1ea0b91cdb16091e5d91c9d3af21bd9c.Description
Problem
Rocky Linux 8's hwloc 2.2.0 is too old for the NIXL LIBFABRIC build. Installing the fallback under
/usr/localand preferring it globally changes the hwloc selected by Open MPI and other consumers.A successful container build also does not establish that KV cache V2 transfers work through the NIXL LIBFABRIC backend on EFA hardware.
Solution
/opt/nvidia/nixl-deps/hwlocand select it for the NIXL build throughPKG_CONFIG_PATH. Preserve suitable existing HPC-X or system hwloc installations and leave global runtime library search configuration unchanged. Runtime use of NIXL LIBFABRIC still requires a compatible hwloc library.Test Coverage
Validation
Reviewed head:
cd59d75d1ea0b91cdb16091e5d91c9d3af21bd9c, based on upstream mainac0c1fda181e5d5cd6f5909d391e522035b4c816.--segmentand with--segment=2. Both runs completed eight matching inference results and eight nonzero EFA KV transfers; all harness roles and Slurm steps passed. Fourteen evidence-validator unit cases also passed inside the image.c097a6f29ec28c9d516a27818599efe7b2b54796, CI wheel sourceb2ade286de557b8dec22d81d6f7bb1e244e2f255, and the formal NGC PyTorch 26.09 image at platform digestsha256:6435f9aaa7e0a6e0b37047d031b5300fb7e733759895541df99c93e09d18b6eb. They used NIXL 1.5.2 and AWS libfabric 2.7.0amzn2.0 withoutNIXL_DISABLE_CUDA_ADDR_WA, through the repository's Slurm launcher with task-local wheel/dependency setup.Full Jenkins L0 and fresh image/GPU validation remain pending for the rebased head.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR follows TRT-LLM Coding Guidelines to the best of your knowledge.
Test cases are provided for new code paths (see test instructions).
If PR introduces API changes, an appropriate PR label is added:
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities.
CODEOWNERS updated if ownership changes.
Documentation updated as needed.
Update the architecture diagram if there is a significant design change.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.