Conversation
ocharles
approved these changes
Sep 22, 2026
ocharles
left a comment
ocharles
left a comment
Contributor
There was a problem hiding this comment.
I guess the point of the class is we can derive DBSequence for something like UserId? Does that work if the underlying DBType talks about a domain type (like our use user_id in our production database`)?
Contributor
Author
I see, we have a DOMAIN type. I think that should work fine, or at least, this isn't doing anything particularly different to what we already do and that works? |
Contributor
Author
|
I wonder if I should just move |
We add a new DBSequence typeclass to track database types that can be used in sequences. This is basically all sizes of integers (Int16,Int32,Int64). They are the types that `nextval` can generate. Previously we forced this to be only Int64. It's up to the user to ensure that the correct type is being used with the correct postgres sequence.
Contributor
|
Hard to say! Maybe for now keep this as you have it |
ocharles
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a new DBSequence typeclass to track database types that can be used in sequences. This is basically all sizes of
integers (Int16,Int32,Int64). They are the types that
nextvalcan generate.Previously we forced this to be only Int64.
It's up to the user to ensure that the correct type is being used with the correct postgres sequence.
Resolves #328