Skip to content

Fix Char test failing from hitting NULL chars #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeofilC merged 1 commit into from
Sep 22, 2026
+9 −1
Merged

Fix Char test failing from hitting NULL chars #420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/20260921_153711_teofilcamarasu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Avoid generating NULL characters in the test suite as postgres doesn't accept these.
7 changes: 6 additions & 1 deletion rel8/tests/Main.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ testDBType getTestDatabase = testGroup "DBType instances"
[ dbTypeTest "Bool" Gen.bool
, dbTypeTest "ByteString" $ Gen.bytes (Range.linear 0 128)
, dbTypeTest "CalendarDiffTime" genCalendarDiffTime
, dbTypeTest "Char" Gen.unicode
, dbTypeTest "Char" genChar
, dbTypeTest "CI Lazy Text" $ mk . Data.Text.Lazy.fromStrict <$> genText
, dbTypeTest "CI Text" $ mk <$> genText
, dbTypeTest "Composite" genComposite
Expand Down Expand Up @@ -672,6 +672,11 @@ testDBType getTestDatabase = testGroup "DBType instances"
Rel8.many . Rel8.many . Rel8.many . (Rel8.catListTable >=> Rel8.catListTable >=> Rel8.catListTable)
diff res''' (==) [[[x, y]]]

genChar :: Gen Char
genChar =
-- Filter out NULL as that isn't accepted by Postgres
Gen.filter (/= '\0') Gen.unicode

genScientific :: Gen Scientific
genScientific = (/ 10) . fromIntegral @Int @Scientific <$> Gen.integral (Range.linear (-100) 100)

Expand Down
Loading