feat(fiber): upgrade FNN integration to the final 0.9.0 release - #510
Conversation
Adapt offckb's Fiber (FNN) support to the official v0.9.0 release, replacing the 0.9.0-rc7 pre-release previously pinned. - Bump the default FNN version to 0.9.0 and re-derive the pinned download SHA-256 digests from the v0.9.0 release tarballs. - Re-pin the ckb/fiber submodule to the v0.9.0 tag commit (e6cb7ac). - Update README/Makefile version and commit references. - The bundled Fiber contracts and testnet-config.yml are byte-identical between 0.9.0-rc7 and 0.9.0, and the RPC surface and CLI flags offckb uses are unchanged, so no devnet-format or config-generation change is needed.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe CLI now targets Fiber v0.9.0 instead of release candidate ChangesFiber v0.9.0 upgrade
Merge Risk: ⚪ Minimal · up to This PR updates Fiber support from 0.9.0-rc7 to the final 0.9.0 release, including version pins, checksums, documentation, and tests. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Warning Your free Security trial is over. An organization admin can activate billing to continue. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
) (#511) Adapt offckb's Fiber (FNN) support to the official v0.9.0 release, replacing the 0.9.0-rc7 pre-release previously pinned. - Bump the default FNN version to 0.9.0 and re-derive the pinned download SHA-256 digests from the v0.9.0 release tarballs. - Re-pin the ckb/fiber submodule to the v0.9.0 tag commit (e6cb7ac). - Update README/Makefile version and commit references. - The bundled Fiber contracts and testnet-config.yml are byte-identical between 0.9.0-rc7 and 0.9.0, and the RPC surface and CLI flags offckb uses are unchanged, so no devnet-format or config-generation change is needed. Co-authored-by: humble-little-bear <retric@ckba.build>
Summary
Adapt offckb's Fiber (FNN) support from the
0.9.0-rc7pre-release to the final FNN v0.9.0 release (per [RET-350]).What changed
SUPPORTED_FNN_VERSIONS/DEFAULT_FNN_VERSIONnow target0.9.0;src/cfg/setting.tsdefault bumped from0.9.0-rc7to0.9.0.v0.9.0release tarballs (they necessarily changed from rc7).ckb/fibersubmodule — re-pinned to thev0.9.0tag commite6cb7ac(wasbc361aa/rc7).fiber-install.test.tspackage-name assertions moved from0.9.0-rc7to0.9.0.Why nothing else needed to change
I diffed the
0.9.0-rc7→v0.9.0transition on the upstream repo:auth,funding_lock,commitment_lock) are byte-identical between rc7 and v0.9.0.config/testnet/config.ymltemplate offckb uses for its devnet is byte-identical — already matches offckb's bundledckb/devnet/specs/fiber/testnet-config.yml.node_info,connect_peer,list_peers) and the CLI flags it uses (-c,-d,-s,--rpc-enabled-modules,--version) are unchanged in v0.9.0.Verified the
0.9.0binary directly:fnn --versionprints0.9.0, which the existinggetVersionFromBinaryregex matches, and the package layout matches the installer's expectations.Validation
npx jest tests/fiber-*— 9 suites / 91 tests pass.npx tsc --noEmit— clean.npx eslinton changed files — clean.