feat(guidelines): import shared primitives from a neutral home - #25
Open
pallaoro wants to merge 2 commits into
Open
feat(guidelines): import shared primitives from a neutral home#25pallaoro wants to merge 2 commits into
pallaoro wants to merge 2 commits into
Conversation
Reuse-before-you-build told the agent to find an existing primitive but said nothing about where to import it from, so "reuse" was satisfied by reaching sideways into another feature's route dir — coupling the two and keeping a Feature* name on generic code. Adds a §7 bullet: hoist the generic part to a domain-neutral module, name it for what it does, and have both features import that. Fanned out to every agent rule file. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse-before-you-build told the agent to find an existing primitive but
said nothing about where to import it from, so "reuse" was satisfied by
reaching sideways into another feature's route dir — coupling the two and
keeping a Feature* name on generic code. Adds a §7 bullet: hoist the
generic part to a domain-neutral module, name it for what it does, and
have both features import that. Fanned out to every agent rule file.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com