Skip to content

hotfix/cp-12673-anrs-while-an-app-banner-is-displayed-layout-loop-in - #387

Merged
unnaticleverpush merged 2 commits into
masterfrom
hotfix/cp-12673-anrs-while-an-app-banner-is-displayed-layout-loop-in
Oct 16, 2026
Merged

unnaticleverpush merged 2 commits into
masterfrom
hotfix/cp-12673-anrs-while-an-app-banner-is-displayed-layout-loop-in

Conversation

@unnaticleverpush

@unnaticleverpush unnaticleverpush commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Fix HTML banner ANR caused by a layout listener that never unregisters


Summary by cubic

Fixes the ANR caused by an HTML banner layout listener that never unregisters, so banners no longer trigger an endless layout loop while displayed.

  • The global layout listener now removes itself after the first layout pass instead of running again on every layout request.
  • Adds a zero-size guard in AppBannerCarouselAdapter before applying banner UI adjustments.

Written for commit 790caba. Summary will update on new commits.

View guided diff Turn on auto-fix

Fix HTML banner ANR caused by a layout listener that never unregisters
@unnaticleverpush unnaticleverpush self-assigned this Oct 9, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread cleverpush/src/main/java/com/cleverpush/banner/AppBannerCarouselAdapter.java Outdated

Copy link
Copy Markdown

@divocp, could you please review the PR? One more approval to go!

@unnaticleverpush
unnaticleverpush merged commit 9e4dbd0 into master Oct 16, 2026
4 of 5 checks passed
@unnaticleverpush
unnaticleverpush deleted the hotfix/cp-12673-anrs-while-an-app-banner-is-displayed-layout-loop-in branch October 16, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants