Repository navigation
hotfix/cp-12673-anrs-while-an-app-banner-is-displayed-layout-loop-in - #387
Merged
unnaticleverpush merged 2 commits intoOct 16, 2026
Conversation
Fix HTML banner ANR caused by a layout listener that never unregisters
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
unnaticleverpush
requested review from
akshay-g-jadhav,
divocp,
namdev-jagtap and
snuricp
October 9, 2026 12:00
akshay-g-jadhav
approved these changes
Oct 12, 2026
namdev-jagtap
approved these changes
Oct 13, 2026
|
@divocp, could you please review the PR? One more approval to go! |
divocp
approved these changes
Oct 15, 2026
unnaticleverpush
deleted the
hotfix/cp-12673-anrs-while-an-app-banner-is-displayed-layout-loop-in
branch
October 16, 2026 06:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix HTML banner ANR caused by a layout listener that never unregisters
Summary by cubic
Fixes the ANR caused by an HTML banner layout listener that never unregisters, so banners no longer trigger an endless layout loop while displayed.
AppBannerCarouselAdapterbefore applying banner UI adjustments.Written for commit 790caba. Summary will update on new commits.