Add metric tracking procedure HTTP request wait time - #5862
Open
gefjon wants to merge 1 commit into
Open
Conversation
I initially set out to resolve a TODO instructing us to: `// TODO(procedure-metrics): record size in bytes of response, time spent awaiting response.` It turns out we already are tracking size in bytes of request and response, so all that's left was to track time. I also added a unit test of the existing functionality. Note that the test is entirely vibe-coded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
I initially set out to resolve a TODO instructing us to:
// TODO(procedure-metrics): record size in bytes of response, time spent awaiting response.It turns out we already are tracking size in bytes of request and response, so all that's left was to track time.I also added a unit test of the existing and new functionality. Note that the test is entirely vibe-coded.
API and ABI breaking changes
n/a
Rollback safety impact
n/a
Expected complexity level and risk
1: metrics, and not even complicated ones.
Testing