Fix bug complaining about csharp on Mac when calling dev command - #5867
Merged
Conversation
lisandroct
marked this pull request as draft
September 3, 2026 18:14
lisandroct
marked this pull request as ready for review
September 3, 2026 19:03
rekhoff
approved these changes
Sep 3, 2026
rekhoff
left a comment
rekhoff
left a comment
Contributor
There was a problem hiding this comment.
The changes make sense to me as a path to resolve the outstanding bug, but I have not personally tested them on a Mac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
In #5571, we were always selecting a default dotnet version and passing it down to
init. Obviously, when we were not targeting C#, the CLI would later complain that the dotnet version wasn't required. Effectively, if you were callingspacetime dev --template basic-rs, we were later doingspacetime init --template basic-rs --dotnet-version 10.This PR fixes that behavior.
API and ABI breaking changes
None. This only changes CLI.
Rollback safety impact
n/a
Expected complexity level and risk
spacetime devbehavior. That being said, it touches howdevinteracts withinit,generateandpublish(which was the source of the issue).Testing
spacetime devwith C# and Rust templates successfully on Linux