Repository navigation
feat(code): add agent-qa workflow to shared QA skills - #344
Open
pranshuchittora wants to merge 1 commit into
Open
pranshuchittora wants to merge 1 commit into
pranshuchittora wants to merge 1 commit into
Conversation
- Add selected-test and saved-run guidance to closedloop-core. - Advance both manifests and generate documentation for 1.6.0. - Derive the launcher test replacement version from the manifest. Testing: 90 core tests, six manifest tests, lint and types pass. Local installer copies match; plugin and skill validation pass. Risks: External agent-qa execution still needs a configured runtime. No live application or provider execution was performed.
Collaborator
|
Beginning a code-review. Please allow time for me to finish before merging the PR |
shafty023
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
closedloop-core:agent-qafor selected web/mobile regressions, saved-run evidence review and memidex provenance. agent-qa from vostride combines natural-language tests with advanced memory and self-improvement. The skill uses an already configured external CLI, preserves recorded verdicts and build scope, and keeps read-only review separate from execution or memory changes.The original instructions are Apache-2.0; the separately licensed agent-qa runtime is not bundled. Both core manifests advance from 1.5.2 to 1.6.0. The repository's
/update-documentationworkflow updated the changelog and plugin README, including its required independent inventory review.The required version bump exposed a hardcoded launcher-test replacement version (
1.5.3). The fixture now derives a newer patch version from the manifest, preserving the cache-update and fallback assertions; runtime launcher behavior is unchanged.Validation:
uv sync --frozen --group devwith Python 3.13.uv run --frozen pytest plugins/closedloop-core/tools/python/ -q— 90 passed, including the new skill in the existing frontmatter contract.uv run --frozen ruff check .anduv run --frozen pyright— pass.tools/plugin-manifests:npm ci,npm run typecheck,npm test— six tests pass.claude plugin validate plugins/closedloop-core, skill frontmatter, five shell examples andgit diff --check— pass.skills1.7.4 local installation for Claude Code and Codex — both skill files match their sources in each installed copy.Validation covers the contributed instructions, packaging and affected plugin. No live agent-qa application/provider run or harness compatibility evaluation is claimed.