Prevent swallowed timeouts from wedging sync workers - #379
Merged
Conversation
AlecRosenbaum
commented
Aug 14, 2026
|
|
||
| def handle_death_penalty(self, signum: int, frame: Any) -> None: | ||
| if self.retries >= 3: | ||
| sys.exit(1) |
Contributor
Author
There was a problem hiding this comment.
should I use os._exit instead?
thomasst
approved these changes
Aug 18, 2026
thomasst
left a comment
thomasst
left a comment
Member
There was a problem hiding this comment.
I'm assuming we deliberately don't want to do any cleanup here (such as threading._shutdown() etc), so _exit is probably fine. Are we able to log or print an error safely here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents sync workers from remaining indefinitely wedged when asynchronous task handling swallows a hard-timeout exception. It retries timeout delivery before terminating the worker so its supervisor can replace it.