Add suse network config support#452
Open
mihaelabalutoiu wants to merge 2 commits into
Open
Conversation
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
2 times, most recently
from
9afb3e3 to
918f222
Compare
Dany9966
requested changes
Jul 2, 2026
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
mihaelabalutoiu
force-pushed
the
add-suse-network-config-support
branch
from
918f222 to
6d19fac
Compare
Dany9966
requested changes
Jul 3, 2026
|
|
||
| def _get_ifcfg_nm_controlled(self): | ||
| if self._version_supported_util(self._version, minimum=15): | ||
| return "yes" |
Contributor
There was a problem hiding this comment.
Did you check on suse machines 12 and 15? Does only 15 need nm_controlled to be enabled?
| return "yes" | ||
| return "no" | ||
|
|
||
| def _backup_nmconnection_files(self, backup_file_suffix=".bak"): |
Contributor
There was a problem hiding this comment.
The redhat._backup_nm_connection_files should be refactored into base and re-used instead of overriding. As a matter of fact, any method that can be re-used from redhat should be refactored into base and used here. There's no need to override everything here, unless there's something that really is different.
IMO the only methods added in this PR that need to be implemented here are disable_predictable_nic_names, and set_net_config. The rest should come from base.
| "GRUB_CMDLINE_LINUX", | ||
| {"opt_type": "key_val", "opt_key": "biosdevname", "opt_val": 0}) | ||
| self._write_file_sudo("etc/default/grub", cfg.dump()) | ||
| self._execute_update_grub() |
Contributor
There was a problem hiding this comment.
Please replace this with self._schedule_grub2_update().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.