Repository navigation
gardener: Upgrade Gardener to v0.1.15 and let mention-reply fix merge conflicts - #235
Conversation
|
commit: |
| On a pull request's conversation your checkout is that pull request's head; anywhere else it is | ||
| the default branch, at the commit this run started from. Read other pull requests with the | ||
| provider API. |
There was a problem hiding this comment.
🔴 Separate pull requests inherit existing changes
When a pull request comment asks for a separate PR, branch.create starts from that PR's head. The new-PR flow targets the default branch, so the separate PR includes the original changes.
Learn more
The task handles new code requests by creating a branch from the run's checkout and opening it against the default branch. For comments on a pull request, the new checkout is that pull request's head, even when the maintainer asks for a separate change rather than an update to that pull request. The resulting branch carries both sets of changes, and the new pull request shows them together.
Example: On a pull request that changes the filesystem API, a maintainer comments asking for a separate documentation PR. The new documentation PR also contains the filesystem API commits.
Recommended fix: Split the new-PR path from the existing-PR update path. For a separate PR requested in a pull request conversation, start from the default branch and build the change there rather than branching from the checked-out PR head; if the task cannot switch to a clean default-branch checkout, decline that route instead of opening a mixed PR.
Was this helpful? React with 👍 or 👎 to provide feedback.
…sation and fix the manual review-fix note
Gardener can now update open pull requests when a maintainer asks on them, including fixing merge conflicts. Conflicts are resolved with a merge commit, so the pull request's history is never rewritten.
What
@gardener-cfcan now do on a pull request.gardener/or CODEOWNERS files, and merges touching.gitattributes,.gitmodules, submodules or more than 1,000 files get an explanation instead of a change.Safeguards
<<<<<<<or>>>>>>>lines.What changes in this repository
mention-reply: checks out the pull request's head when the comment is on one, and gains therepository.merge_basetool and thecommit.merge_baseeffect.commit.createandcommit.merge_basemay write to any branch except the default. The instructions now cover changing a pull request, merge conflicts, and when to rebase. Asked on a pull request for a separate pull request, it declines and suggests an issue, because its branch would carry the pull request's changes. Its bundle hash changes.gardener-mention-reply.ymlgains apull_requestinput for manual runs and runs one round per pull request at a time.gardener-pr-review-fix.ymlpasses the pull request number instead of the head SHA, so a manual run given a pull request number now checks out its head and can run a review round; its instructions say so, which changes its bundle hash.triageanddependabot-mergeare unchanged.gardener:generatepoints at@scuffi/gardener@0.1.15.Tested on a demo repository and on scuffi/gardener first
git rebaseand force-push were each declined with an explanation.