Repository navigation
Conversation
WorkspaceProxy and WorkspaceServiceProxy resolved their host Durable Object with ns.get(ns.idFromString(id)). A container or Dynamic Worker outlives the object, so after an eviction or a deploy the proxy is often the first caller, and an instance woken through idFromString() has no ctx.id.name for its whole lifetime. agents' Lifecycle then refuses to start with "could not determine its Durable Object name". WorkspaceRef, WorkspaceProxyProps and WorkspaceServiceProxyProps take an optional name. The proxies address the object with idFromName(name) when that yields the same id, and fall back to idFromString(id) otherwise, so id stays the authority on which object is meant. The container hosts and WorkerShellBackend fill the name in from ctx.id.name when the reference points at the object they run in, so the common same-object setup is fixed without code changes. Fixes #243
馃 Changeset detectedLatest commit: ccc6f98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| // the proxy resolves env[binding].get(id).getWorkspace() | ||
| // on the host side. | ||
| HOST: ctx.exports.WorkspaceServiceProxy({ props: workspace }), | ||
| HOST: ctx.exports.WorkspaceServiceProxy({ props: withHostName(workspace, ctx) }), |
There was a problem hiding this comment.
馃攳 Automatic name propagation remains untested end-to-end
The tests cover inferred names and name-aware routing separately. No workerd test confirms a backend passes its inferred name to a proxy, leaving the wake fix's wiring unverified.
Was this helpful? React with 馃憤 or 馃憥 to provide feedback.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkspaceProxy and WorkspaceServiceProxy resolved their host Durable Object with ns.get(ns.idFromString(id)). A container or Dynamic Worker outlives the object, so after an eviction or a deploy the proxy is often the first caller, and an instance woken through idFromString() has no ctx.id.name for its whole lifetime. agents' Lifecycle then refuses to start with "could not determine its Durable Object name".
WorkspaceRef, WorkspaceProxyProps and WorkspaceServiceProxyProps take an optional name. The proxies address the object with idFromName(name) when that yields the same id, and fall back to idFromString(id) otherwise, so id stays the authority on which object is meant. The container hosts and WorkerShellBackend fill the name in from ctx.id.name when the reference points at the object they run in, so the common same-object setup is fixed without code changes.
Fixes #243