Skip to content

test: exercise homepage visual regression - #815

Draft
stritt wants to merge 1 commit into
mainfrom
stritt/test-visual-regression
Draft

stritt wants to merge 1 commit into
mainfrom
stritt/test-visual-regression

Conversation

@stritt

@stritt stritt commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

purpose

this is an intentional, temporary visual-regression test. it changes one homepage button from secondary to destructive so the visual report should:

  • select the homepage based on the changed HomeGrid.tsx file
  • report one focused, real visual change
  • show the button color difference without unrelated animation or crop noise

do not merge. close this pr after inspecting the visual regression report.

validation

  • kumo package build

  • docs typecheck

  • targeted lint and format checks

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: this temporary draft exists only to exercise the visual-regression workflow

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows:

  • Additional testing not necessary because: this intentionally changes one existing homepage demo solely to trigger the visual-regression workflow

@ask-bonk

ask-bonk Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

LGTM!

Review notes
  • Planned checks: verify PR test: exercise homepage visual regression #815 and its existing reviews, inspect the complete changed component and applicable docs conventions, then run a focused static validation if available.
  • Verified PR test: exercise homepage visual regression #815 is open, draft, and at the requested head SHA; it has no prior reviews. The sole change changes the first homepage Button to the supported destructive variant, matching the PR's intentionally temporary visual-regression scenario.
  • Confirmed destructive is a documented Button variant and that secondary is the prior default. git diff --check completed cleanly. The focused lint command could not run because pnpm is unavailable in this runner.
  • Checked PR workflow status: formatting has passed; build, docs, visual-contract, and analysis checks are still pending. No actionable regression was identified in the reviewed change.

github run

@pkg-pr-new

pkg-pr-new Bot commented Sep 18, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@815

commit: 8e1e537

@github-actions

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.1 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.9 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.9 KB
Chart (root) 247.1 KB 71.1 KB 60.8 KB
Chart (components/chart) 247.0 KB 71.1 KB 60.8 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.1 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.8 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 468.0 KB 349.3 KB

npm tarball: 544 files, 1.49 MB packed, 6.95 MB unpacked.

⚠️ 23 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-globe-land-mask.mjs
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: 8e1e537b

@github-actions

Copy link
Copy Markdown
Contributor

Visual contracts

Linux Chromium references exercised by the PR's visual-contracts job.

1 curated contract

truncating text trigger

truncating text trigger

@github-actions

Copy link
Copy Markdown
Contributor
Visual Regression Report — 1 changed, 0 unchanged

1 screenshot(s) with visual changes:

Home

5,022 px (0.05%) changed

Before After Diff
Before After Diff

Generated by Kumo Visual Regression

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://stritt-test-visual-regression-kumo-docs.design-engineering.workers.dev (commit 8e1e537)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://9143d9fb-kumo-docs.design-engineering.workers.dev 8e1e537 2026-09-18T14:26:36.250Z Visit the dashboard ↗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant