Conversation
Contributor
|
LGTM! Review notes
|
commit: |
Contributor
📐 Bundle SizeConsumer fixtures bundled against
npm tarball: 544 files, 1.49 MB packed, 6.95 MB unpacked.
|
Contributor
Contributor
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://stritt-test-visual-regression-kumo-docs.design-engineering.workers.dev (commit 8e1e537)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




purpose
this is an intentional, temporary visual-regression test. it changes one homepage button from secondary to destructive so the visual report should:
HomeGrid.tsxfiledo not merge. close this pr after inspecting the visual regression report.
validation
kumo package build
docs typecheck
targeted lint and format checks
Reviews
bonk has reviewed the change
automated review not possible because: this temporary draft exists only to exercise the visual-regression workflow
Tests
Tests included/updated
Automated tests not possible - manual testing has been completed as follows:
Additional testing not necessary because: this intentionally changes one existing homepage demo solely to trigger the visual-regression workflow