Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setByPathandgetByPathin@cloudflare/kumo/catalogwalk untrusted, AI-generated JSON Pointer paths against the data model. Both traversed the prototype chain, so a path like/__proto__/pollutedor/constructor/prototype/pollutedcould write toObject.prototype, and/constructoror/toStringcould read prototype members into resolved props / visibility checks.__proto__,constructor, andprototypesegments in bothgetByPathandsetByPath(defense-in-depth).Object.hasOwninstead ofin/ bare indexing so only own properties are traversed.nullintermediates the same as missing (previouslytypeof null === "object"let traversal fall through and throw).length(previouslyRangeError: Invalid array lengthon/items/length/x).setByPath, mirroringgetByPath.No behavior change for plain JSON data models (
DataModel = Record<string, unknown>); array index access (/items/0) still works.Testing
pnpm --filter @cloudflare/kumo test: 59 files, 1403 passedpnpm --filter @cloudflare/kumo lintpnpm --filter @cloudflare/kumo typecheckpnpm vp fmt --checkon changed filesgit diff --check