Skip to content

Fix multibuildpack integration test timeouts (builds #19-22 failures) #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnikolova82 merged 1 commit into from
Oct 9, 2026
+16 −6
Merged

Fix multibuildpack integration test timeouts (builds #19-22 failures) #1178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions src/ruby/integration/multibuildpack_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package integration_test
import (
"path/filepath"
"testing"
"time"

"github.com/cloudfoundry/switchblade"
"github.com/sclevine/spec"
Expand Down Expand Up @@ -43,7 +44,9 @@ func testMultiBuildpack(platform switchblade.Platform, fixtures string) func(*te
deployment, _, err := deploymentProcess.Execute(name, filepath.Join(fixtures, "multibuildpack", "no_gemfile"))
Expect(err).NotTo(HaveOccurred())

Eventually(deployment).Should(Serve(MatchRegexp(`Ruby Version: \d+\.\d+\.\d+`)))
// Extended timeout for multi-buildpack deployment consistency,
// matching the pattern established in d5294b6d.
Eventually(deployment, 90*time.Second, 2*time.Second).Should(Serve(MatchRegexp(`Ruby Version: \d+\.\d+\.\d+`)))
})
})

Expand All @@ -57,8 +60,13 @@ func testMultiBuildpack(platform switchblade.Platform, fixtures string) func(*te
Execute(name, filepath.Join(fixtures, "multibuildpack", "rails72"))
Expect(err).NotTo(HaveOccurred())

Eventually(deployment).Should(Serve(ContainSubstring("Ruby version: ruby 3.")))
Eventually(deployment).Should(Serve(MatchRegexp(`Node version: v\d+\.\d+\.\d+`)))
// The default 20s Eventually timeout has been observed to be insufficient for
// this heavy multi-buildpack Rails 7.2 + Webpacker app, especially under
// parallel test execution. Staging alone takes 4-5 minutes, and app boot can
// take 60-120s. Extended timeout matches the pattern established for JRuby
// (#1140) and other slow-booting fixtures (d5294b6d).
Eventually(deployment, 90*time.Second, 2*time.Second).Should(Serve(ContainSubstring("Ruby version: ruby 3.")))
Eventually(deployment, 90*time.Second, 2*time.Second).Should(Serve(MatchRegexp(`Node version: v\d+\.\d+\.\d+`)))
})
})

Expand All @@ -72,8 +80,9 @@ func testMultiBuildpack(platform switchblade.Platform, fixtures string) func(*te
Execute(name, filepath.Join(fixtures, "multibuildpack", "ruby_calls_go"))
Expect(err).NotTo(HaveOccurred())

Eventually(deployment).Should(Serve(MatchRegexp(`RUBY_VERSION IS \d+\.\d+\.\d+`)))
Eventually(deployment).Should(Serve(MatchRegexp(`go version go\d+\.\d+(\.\d+)?`)))
// Extended timeout for multi-buildpack deployment consistency.
Eventually(deployment, 90*time.Second, 2*time.Second).Should(Serve(MatchRegexp(`RUBY_VERSION IS \d+\.\d+\.\d+`)))
Eventually(deployment, 90*time.Second, 2*time.Second).Should(Serve(MatchRegexp(`go version go\d+\.\d+(\.\d+)?`)))
})
})

Expand All @@ -87,7 +96,8 @@ func testMultiBuildpack(platform switchblade.Platform, fixtures string) func(*te
Execute(name, filepath.Join(fixtures, "multibuildpack", "dotnet_core"))
Expect(err).NotTo(HaveOccurred())

Eventually(deployment).Should(Serve(MatchRegexp(`dotnet: \d+\.\d+\.\d+`)))
// Extended timeout for multi-buildpack deployment consistency.
Eventually(deployment, 90*time.Second, 2*time.Second).Should(Serve(MatchRegexp(`dotnet: \d+\.\d+\.\d+`)))
})
})
}
Expand Down
Loading