Skip to content

fix: remove missing video player icon assets and fail build on downlo… #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulBoye-py merged 1 commit into from
Oct 3, 2026
Merged

fix: remove missing video player icon assets and fail build on downlo… #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions next-cloudinary/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@
},
"./package.json": "./package.json",
"./cld-video-player.css": "./dist/cld-video-player.css",
"./dist/cld-video-player.css": "./dist/cld-video-player.css",
"./cloudinary_icon_for_black_bg.svg": "./dist/cloudinary_icon_for_black_bg.svg",
"./dist/cloudinary_icon_for_black_bg.svg": "./dist/cloudinary_icon_for_black_bg.svg",
"./cloudinary_icon_for_white_bg.svg": "./dist/cloudinary_icon_for_white_bg.svg",
"./dist/cloudinary_icon_for_white_bg.svg": "./dist/cloudinary_icon_for_white_bg.svg"
"./dist/cld-video-player.css": "./dist/cld-video-player.css"
},
"types": "./dist/next-cloudinary.cjs.d.ts",
"files": [
Expand Down Expand Up @@ -70,11 +66,7 @@
"importConditionDefaultExport": "default",
"extra": {
"./cld-video-player.css": "./dist/cld-video-player.css",
"./dist/cld-video-player.css": "./dist/cld-video-player.css",
"./cloudinary_icon_for_black_bg.svg": "./dist/cloudinary_icon_for_black_bg.svg",
"./dist/cloudinary_icon_for_black_bg.svg": "./dist/cloudinary_icon_for_black_bg.svg",
"./cloudinary_icon_for_white_bg.svg": "./dist/cloudinary_icon_for_white_bg.svg",
"./dist/cloudinary_icon_for_white_bg.svg": "./dist/cloudinary_icon_for_white_bg.svg"
"./dist/cld-video-player.css": "./dist/cld-video-player.css"
}
},
"___experimentalFlags_WILL_CHANGE_IN_PATCH": {
Expand Down
34 changes: 15 additions & 19 deletions next-cloudinary/scripts/copy-assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,6 @@ const assets = [
{
uri: `https://unpkg.com/cloudinary-video-player@${PLAYER_VERSION}/dist/cld-video-player.min.css`,
name: 'cld-video-player.css'
},
{
directory: 'fonts',
assets: [
`https://unpkg.com/cloudinary-video-player@${PLAYER_VERSION}/dist/fonts/cloudinary_icon_for_black_bg.svg`,
`https://unpkg.com/cloudinary-video-player@${PLAYER_VERSION}/dist/fonts/cloudinary_icon_for_white_bg.svg`,
]
}
];

Expand Down Expand Up @@ -44,14 +37,6 @@ async function copyAssets() {
await downloadFile(uri, writePath);

console.log(`Wrote ${uri} to ${writePath}`);
} else if ( typeof asset.directory === 'string' ) {
await mkdirp(path.join(distPath, asset.directory));

for ( const dirAsset of asset.assets ) {
const writePath = path.join(distPath, asset.directory, path.basename(dirAsset));
await downloadFile(dirAsset, writePath);
console.log(`Wrote ${dirAsset} to ${writePath}`);
}
}
}

Expand All @@ -63,16 +48,27 @@ async function copyAssets() {
*/

function downloadFile(assetUrl: string, writePath: string) {
return new Promise<void>((resolve) => {
const file = createWriteStream(writePath);
return new Promise<void>((resolve, reject) => {
https.get(assetUrl, function(response) {
// Fail instead of writing an error page (e.g. a 404) to disk as the asset
if ( response.statusCode !== 200 ) {
response.resume();
reject(new Error(`Failed to download ${assetUrl}: HTTP ${response.statusCode}`));
return;
}

const file = createWriteStream(writePath);
response.pipe(file);
file.on('finish', () => {
file.close();
resolve();
});
});
file.on('error', reject);
}).on('error', reject);
})
}

copyAssets();
copyAssets().catch((error) => {
console.error(error);
process.exit(1);
});
Loading