Repository navigation
fix: find skills in category folders and require Node.js 22 - #5
Open
PaulBoye-py wants to merge 1 commit into
Open
PaulBoye-py wants to merge 1 commit into
PaulBoye-py wants to merge 1 commit into
Conversation
strausr
reviewed
Nov 6, 2026
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=18.0.0" | ||
| "node": ">=22.0.0" |
Collaborator
There was a problem hiding this comment.
engines doesn't enforce the Node.js version by default but is only a warning, or nothing at all, unless they've turned on engine-strict.
We can have the CLI check process.versions.node and stop or warn with a clear message
strausr
reviewed
Nov 6, 2026
| } | ||
|
|
||
| if (!sourceDir) { | ||
| if (remoteInstallAvailable) { |
Collaborator
There was a problem hiding this comment.
This sits inside for (const targetRoot of targetRoots). If the user picks Claude plus Cursor/Copilot/Generic, there are two target folders (.claude/skills and .agents/skills), so every missing skill gets the same warning twice.
Instead we can work out sourceDir for each skill once, before the targetRoots loop, and warn there.
strausr
reviewed
Nov 6, 2026
| @@ -20,7 +20,7 @@ | |||
| "author": "Cloudinary, Inc.", | |||
| "license": "MIT", | |||
Collaborator
There was a problem hiding this comment.
Need to update lockfle to match version
strausr
requested changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the CLI so it installs the current skills from the Cloudinary skills repo again, and raises the Node.js requirement to 22 for next-cloudinary v7.
Problem
The CLI clones the skills repo when it creates a project and copies
cloudinary-next,cloudinary-docsandcloudinary-transformationsinto it. It falls back to copies bundled in the CLI only if the clone fails.On 18 September the skills repo moved its skills into category folders (
skills/frameworks/…,skills/platform/…). The CLI only looks inskills/<name>, so it no longer finds any of the three. It then silently uses the bundled copies, even though the clone worked. Two of the bundled copies (docs and transformations) are already out of date.Changes
findSkillSourceDiralso looks in each category folder underskills/, and only accepts a folder that contains aSKILL.md.engines.noderaised from>=18.0.0to>=22.0.0, and the README requirement changed from "current LTS" to "Node.js 22 or later". The template now uses next-cloudinary v7 (chore: upgrade next-cloudinary to v7 create-cloudinary-next-template#1), which requires Node.js 22.cloudinary-docsandcloudinary-transformationscopies from the skills repo.The bundled
cloudinary-nextcopy is unchanged (it matches the skills repo's current version). The v7 update to that skill is in cloudinary-devs/skills#28. With this fix, the CLI picks it up from the skills repo as soon as it's merged; the bundled copy can be refreshed afterwards.Testing
node cli.js --headless --cloudName demo --projectName … --aiTools claude --aiTools cursor --installDeps false:.claude/skillsand.agents/skills) are identical to the skills repo'smain. The MCP config files are still written.Not changed
The release workflow still uses Node.js 20, which is end-of-life. It's left for a separate change, since it can only be tested by running a release.