Repository navigation
Feat: Add cloudinary-upload skill - #21
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
@njb90 Haven't done a full review - just a 5 minute skim with an eye for a few specific things in the new upload skill. Added a few high-level comments for your consideration specifically in the context of our other efforts around retention and growth. In general, we should try to make sure this skill encourages the same best practices we're in the process of pushing via other initiatives & not just pure factual docs on how things work.
@strausr - pls also review the new upload skill w/ this in mind.
Separately, I'd like to suggest that we split the restructure & the new upload skill into two separate PRs so we can release the catalog restructure faster while enabling the skills team to put a bit more thought/discussion into the upload skill before publishing it
-
I realize we can always release an initial upload skill, and then push more improvements later, but we also need to consider that any improvements we add won't help retrospectively for any customers who install the first version when we first announce its availability - thus I'd like us to invest a bit more in our v1.0, while still trying to prioritize for a fairly quick release.
-
We should already add instructions in the upload skill to pass the new referral heade for tracking any time the agent uses this skill to help build the uploads via REST endpoints + quickly validate that agents follow the instruction as expected with promptfoo. This should definitely be done before the first release to ensure we have that tracking from the start.
jackieros
left a comment
jackieros
left a comment
There was a problem hiding this comment.
Should we update the version (minor-minor) on all the skills that were 'renamed' due to the new paths, or should we consider that not modified since the folders shouldn't affect the agents?
carlevison
left a comment
carlevison
left a comment
There was a problem hiding this comment.
A couple of initial comments - also not reviewed in-depth yet.
Runs the real skills CLI against the checkout and fails when the number of discovered skills differs from the number of SKILL.md files, so a skill dropped by bad frontmatter or wrong depth cannot merge silently. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
README groups the skills table by category, leads the install section with --skill examples. CONTRIBUTING.md records the layout, frontmatter, description-shape, cross-reference, versioning and local-check rules. specs/ is gitignored. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
GitHub Actions sets CI, which makes the skills CLI colour its output, so 'Found 5 skills' arrived as 'Found \e[32m5\e[39m skills' and the grep never matched (found=0, expected=5). Set NO_COLOR and strip any remaining ANSI escapes before grepping. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copied from feat/cloudinary-upload-skill into skills/platform/. Adds a Related Skills section pointing at cloudinary-next, cloudinary-react and cloudinary-docs, and appends the framework pointer to the description. Ships at 1.0.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
298229d to
809ce37
Compare
Make the skill opinionated about best practices rather than a docs restatement, per PR #21 review: - Lead with default best practices; recommend upload presets for any repeated upload pattern and list recommended preset settings - Add Transformations on Upload: eager vs incoming, no f_auto at upload time, delivery string must match eager, named transformations - Add Naming and Folders: public_id strategies, use_filename, asset_folder vs folder by folder mode, display_name, overwrite - Add SDK vs Upload widget vs REST guidance and a widget snippet - Add install_source and referrer params to every documentation link - Align structure and voice with the other skills (self-validation checklist, common mistakes, progressive-disclosure resources) and the CONTRIBUTING description shape Correct facts checked against the docs: unsigned precedence favours the preset, the unsigned allow-list was incomplete, and remote upload does not use type=fetch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
sharon-yelenik
left a comment
sharon-yelenik
left a comment
There was a problem hiding this comment.
Very comprehensive and detailed. I'm sure this will help developers a lot.
Some comments inside.
- Remove max_bytes, which is not a working upload parameter - Lead signature guidance with the minimal timestamp + upload_preset case - Fix signing rules to match the SDKs: comma-separated arrays, & encoded as %26, empty params omitted; fix unsorted example - Make naming options neutral and drop the random-ID warning - Add upload-once guidance, access control, parallel uploads and rate limiting, moderation workflow, and an analysis-on-upload pointer - Fix PDF resource_type, Console API Keys path, and human-only actions - Remove the unrelated f_auto:video troubleshooting row Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # .github/workflows/skills-discovery.yml # CONTRIBUTING.md # README.md
…rated-content Run scripts/check-version-block.sh --fix, required by main's new version-check-block CI job after merging main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Pushed by mistake alongside the cloudinary-upload skill in #21. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Adds a
cloudinary-uploadskill covering signed and unsigned uploads, upload presets, large files, remote/fetch uploads and signature generation.Per review, the catalog restructure was split out to #22 so it can ship first. This branch is stacked on it; once #22 merges the diff here shrinks to the skill plus two README lines. Existing review threads on the upload skill remain on this PR.
Before publishing
?install_source=skillspack&referrer=upload-skill) on all doc linksSuggested follow-up to be implemented later: validate with promptfoo