Repository navigation
chart: fix invalid YAML for nested storage fields (rateLimit) - #275
Merged
Merged
Conversation
den-dw
requested review from
aiivashchenko,
arttor,
fa-at-pulsit and
schucly
as code owners
October 23, 2026 09:42
den-dw
force-pushed
the
fix/chart-nested-storage-fields
branch
from
October 23, 2026 11:32
fcbff33 to
821f03d
Compare
arttor
requested changes
Oct 26, 2026
arttor
left a comment
arttor
left a comment
Contributor
There was a problem hiding this comment.
Thanks, the fix looks good. The chart is published at release with the version from Chart.yaml, so please bump deploy/chorus/Chart.yaml version from 0.4.0 to 0.4.1. After that it's ready to merge.
Contributor
|
please also rebase onto main to make tests pass on CI |
'{{ $key }}: {{ $value | toYaml | nindent 6 | trim }}' trimmed the newline a nested map needs and indented it at the key's level, so e.g. storage rateLimit produced 'rateLimit: enabled: true' and the proxy/worker config failed to parse. Render maps and lists as a nested block, keep scalars inline; output for scalar-only storages is unchanged.
Signed-off-by: Denis Ivanov <dendw.work@gmail.com>
Signed-off-by: Denis Ivanov <dendw.work@gmail.com>
den-dw
force-pushed
the
fix/chart-nested-storage-fields
branch
from
October 26, 2026 13:47
821f03d to
0a354da
Compare
arttor
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Nested fields of a storage (e.g.
rateLimit) rendered invalid YAML in the proxy and worker config:{{ $key }}: {{ $value | toYaml | nindent 6 | trim }}trims the newline that a nested map needs and indents it at the key's own level. Maps and lists are now rendered as a nested block (indent 8), scalars stay inline; the scalar branch also uses indent 8, so multi-line strings get valid block indentation. For storages with scalar fields only the rendered output is byte-identical tomain(checked with default values and with a two-storage S3 config).Related Issue
Fixes #273
Checklist
Signed-off-byline to certify agreement with the Developer Certificate of Origin (DCO).make testpassing — chart-only change;helm lintandhelm templatewith nestedrateLimitpass, generated configs parse as YAMLNote: By submitting this PR, you agree to license your contributions under the Apache 2.0 License and follow our Code of Conduct.
🤖 Generated with Claude Code