fix(compute_worker): make submission lifecycle idempotent against bro…#2434
Open
AybH26 wants to merge 1 commit into
Open
fix(compute_worker): make submission lifecycle idempotent against bro…#2434AybH26 wants to merge 1 commit into
AybH26 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2433
Summary
compute_workerusestask_acks_late = True, so any worker that dies before acking causes RabbitMQ to redeliver the run payload. The redelivered worker used to re-execute the full lifecycle, with three visible consequences:scoring_worker_hostnamewas overwritten by the second worker.statuswas flipped backwards throughRunning → Scoring → Finishedagain.upload_submission_scoresinserted a secondSubmissionScorerow per leaderboard column, which then crashedSubmission.calculate_scores()withMultipleObjectsReturned.This PR makes the lifecycle idempotent on both sides of the wire (defense-in-depth, Stripe-style: worker short-circuits, server refuses to double-mutate).
What changed
Worker
run_wrappernow probesGET /api/submissions/<id>/worker_state/on entry. If the submission is already terminal it logs the redelivery and returns{"skipped": True}, letting Celery ack the message. NewRun._fetch_submission_statehelper is best-effort — any API error falls through to the legacy path so a transient blip cannot block a legitimate run.API
@action worker_stateonSubmissionViewSet: authenticated by the submissionsecretquery param, returns{status, is_terminal, has_scoring_result, has_prediction_result, worker_attempt_count}, atomically bumps the counter viaF('worker_attempt_count') + 1.check_object_permissionsno longer writesingestion_worker_hostname/scoring_worker_hostnameonce the row is terminal.upload_submission_scoresupserts oneSubmissionScoreper(submission, column)instead of blindly creating duplicates.SubmissionCreationSerializer.updaterefuses status mutations on terminal rows (returns200 OKwith the unchanged instance so the redelivered worker acks cleanly).Model
Submission.worker_attempt_countfield for the audit trail.