Repository navigation
chore(flags): retire ContactPickerMode and FrostedTipCard - #1583
Merged
Merged
Conversation
FrostedTipCard has had no reader since #1220 removed the frosted backdrop and left the flag in place. ContactPickerMode is retired as off, which is what every user already gets. The picker path lost its only entry point when direct-send went (#1419), so turning it on would skip the contacts permission step and leave the reader with an empty picker store. ScopeAwareContactReader now always reads through full access and still falls back to picked contacts when that fails; the picker reader and launcher stay for a future entry point. That reader was the contacts module's only FeatureFlag reference, so `:apps:flipcash:shared:featureflags` leaves its build file. Both DataStore keys stay behind unread, the same as the other retired flags.
github-actions
Bot
added
type: chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two Labs flags. Neither changes what users see.
FrostedTipCard has had no reader since #1220 took out the frosted backdrop and left the flag behind. This is a plain deletion.
ContactPickerMode is retired as off, which is the READ_CONTACTS full-access path every user already runs. Graduating it wasn't an option: the picker lost its only entry point when direct-send was removed (#1419), and
ContactCoordinator.addPickedContactshas no callers. With the flag on, onboarding would skip the contacts permission step and the reader would switch to an empty picker store.FeatureFlag.ContactPickerModeandFeatureFlag.FrostedTipCardgo, along with theirtitle/messageentries and theandroid.os.Buildimport that only the picker flag used.ScopeAwareContactReaderalways reads throughFullAccessContactReader, and still falls back to picked contacts when that read fails.isPermissionRevoked()no longer short-circuits for picker mode.PermissionsPhaseFlowHostalways includes the contacts permission step unlessskipContactsis set, andresumeAtno longer keys on the flag.:apps:flipcash:shared:featureflagsleavesshared/contacts/build.gradle.kts, because the reader was the module's onlyFeatureFlagreference.PickerContactReader,rememberContactAccessHandle's picker launcher, andaddPickedContacts/removeSelectedContactare left in place for when the picker gets a new entry point.Both DataStore keys stay behind unread, the same as the other retired flags.