Repository navigation
chore(protos): follow flipcash2 0.14.0 - #1634
Merged
Merged
Conversation
…auto_assigned Follow the proto renames at the call sites: UpdateTipCard -> UpdateFlipcard in ProfileApi/ProfileService, tip_card_customization -> flipcard_customization in UserProfileMapper, and TipPresets/tip_presets -> SendPresets/send_presets in UserFlagsMapper. Add UserProfile.isUsernameAutoAssigned (default false), map it from the proto, and cache it in ProfileCoordinator's own-profile store. ProfileController sets it when setDisplayName returns an assigned username and clears it on setUsername. Built against the local flipcash2-client-protocol checkout; the pin in libs.versions.toml is not bumped.
bmc08gt
marked this pull request as ready for review
September 30, 2026 17:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the flipcash2 0.14.0 contract (upstream
df1cb04e) and bumps the pin.Blocked on code-payments/flipcash2-client-protocol#20: 0.14.0 isn't published yet, so CI can't resolve the pin. This stays a draft until the release is on Maven Central / tagged.
UpdateFlipcardRPC and its request/response,FlipcardCustomization,SendPresets.isUsernameAutoAssignedon the own-profile model, default false, carried through the own-profile cache. Nothing in the UI reads it yet.tipCard*,TipPresets,TipOrigin, tip card UI) are unchanged; only generated names had to move.ProfileController.setDisplayNamesets the flag when the server returns an assigned username;setUsernameclears it.:apps:flipcash:app:compileDebugKotlinand unit tests for:services:flipcash,shared:profile,shared:userflags,shared:paymentsandfeatures:userflagspass against the local client checkout.