fix(tokens): round the explainer slider's fill at the far end - #1661
Merged
Merged
Conversation
The track uses a square inside corner so the fill ends flush under the thumb. At full position that corner is the track's right edge, so the green fill showed square corners. Clip the track to its pill shape.
github-actions
Bot
added
area: tokens
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the Market Cap explainer slider dragged fully right, the green fill ended in square corners instead of following the track's rounded end.
The track sets
trackInsideCornerSize = 0.dpso the fill ends flush under the thumb mid-drag. At full position that inside corner becomes the track's right edge. Clipping the track toCircleShaperounds both ends; mid-drag the square end is still under the thumb, so nothing changes there.