fix(triage): count builds from origin/code/cash and load .env.local for the event fetch - #1667
Merged
Merged
Conversation
…or the event fetch build-lookup.sh counted commits from the local HEAD, so on a checkout behind origin it rejected a real build (4718 against a local count of 4700). It now fetches and counts from origin/code/cash, the branch builds are cut from, with --ref to override, and checks that the resolved commit has exactly N ancestors. The triage skill's manual event fetch told the agent to source only .env, while bugsnag-top.sh also reads .env.local, where the token lives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build-lookup.shcounted commits from the localHEAD, so on a checkout behind origin it rejected a real build: versionCode 4718 failed with "exceeds current commit count (4700)". Builds are cut fromcode/cash, so the script now fetches and counts fromorigin/code/cash.--ref <ref>counts from somewhere else. The offset maths assumes linear history, so the script now also checks that the resolved commit has exactly N ancestors and fails if not, instead of returning the wrong commit.Step 2 of the triage skill told the agent to source only
.envbefore fetchingevent_url.bugsnag-top.shalso reads.env.local, which is where the token is set, so the manual fetch went out without a token. The step now loads both files in the same shell as the request.The event URL problem from the same triage was already fixed by #1646.