feat(chat): adopt flipcash2 0.17.0 (group descriptions) - #1684
Merged
Merged
Conversation
github-actions
Bot
added
area: network
Map Metadata.description and MetadataUpdate.DescriptionChanged. Send a description on public and private StartChat, and on EditChat through a DescriptionEdit (Set or Clear) so leaving the description unchanged stays distinct from clearing it. Map DESCRIPTION_MODERATED with its flagged category for StartChat and EditChat. Persist the description in a nullable chat_metadata.description column (Room 41 -> 42 auto migration), refresh it from server payloads on upsert, and apply DescriptionChanged from the event stream. An empty description on the wire is stored as null.
bmc08gt
force-pushed
the
chore/flipcash2-0.17.0
branch
from
October 5, 2026 22:21
c0438a0 to
ce33bc9
Compare
bmc08gt
marked this pull request as ready for review
October 5, 2026 22:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: blocked on the flipcash2-client-protocol 0.17.0 release (code-payments/flipcash2-client-protocol#24).
Adopts the 0.17.0 contract (group descriptions), with no UI:
ChatMetadata.description, null when empty, andMetadataUpdate.DescriptionChangeddecoded from the event stream.descriptionon public and privateStartChatParameters, sent only when non-null.EditChatParameters.descriptiontakes aDescriptionEdit(SetorClear); null leaves the wrapper unset, so "unchanged" stays distinct from "cleared".DescriptionModerated(category)onStartChatErrorandEditChatError.chat_metadata.descriptioncolumn (Room 41 → 42 auto migration), refreshed on upsert and updated fromDescriptionChanged.Not handled yet: no caller sends a description, and
DescriptionModeratedfalls through to the generic error alert and reports as "Network" in analytics.